Change in osmo-sgsn[master]: gbproxy: Remove unneeded parse_ctx param

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 22 17:04:46 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11890


Change subject: gbproxy: Remove unneeded parse_ctx param
......................................................................

gbproxy: Remove unneeded parse_ctx param

The only use inside the function is only to log information which should
actually be provided by tmp_parse_ctx of each stored msg.

Change-Id: Ic186b92fa9bd0a2b853a0cf525c6f6feb9493897
---
M src/gprs/gb_proxy.c
1 file changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/90/11890/1

diff --git a/src/gprs/gb_proxy.c b/src/gprs/gb_proxy.c
index 85c3c47..faf4a8b 100644
--- a/src/gprs/gb_proxy.c
+++ b/src/gprs/gb_proxy.c
@@ -324,8 +324,7 @@
 static int gbproxy_flush_stored_messages(struct gbproxy_peer *peer,
 					  struct msgb *msg,
 					  time_t now,
-					  struct gbproxy_link_info* link_info,
-					  struct gprs_gb_parse_context *parse_ctx)
+					  struct gbproxy_link_info* link_info)
 {
 	int rc;
 	struct msgb *stored_msg;
@@ -369,8 +368,8 @@
 			     "NSEI=%d(BSS) failed to send stored message "
 			     "(%s)\n",
 			     msgb_nsei(msg),
-			     parse_ctx->llc_msg_name ?
-			     parse_ctx->llc_msg_name : "BSSGP");
+			     tmp_parse_ctx.llc_msg_name ?
+			     tmp_parse_ctx.llc_msg_name : "BSSGP");
 		msgb_free(stored_msg);
 	}
 
@@ -479,8 +478,7 @@
 		/* The IMSI is now available. If flushing the messages fails,
 		 * then link_info has been deleted and we should return
 		 * immediately. */
-		if (gbproxy_flush_stored_messages(peer, msg, now, link_info,
-					      parse_ctx) < 0)
+		if (gbproxy_flush_stored_messages(peer, msg, now, link_info) < 0)
 			return 0;
 
 		gbproxy_reset_imsi_acquisition(link_info);

-- 
To view, visit https://gerrit.osmocom.org/11890
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic186b92fa9bd0a2b853a0cf525c6f6feb9493897
Gerrit-Change-Number: 11890
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/396220ba/attachment-0001.html>


More information about the gerrit-log mailing list