Change in osmo-ggsn[master]: initialize local variable addr in ippool_new()

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Nov 22 13:16:50 UTC 2018


Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11869 )

Change subject: initialize local variable addr in ippool_new()
......................................................................

initialize local variable addr in ippool_new()

Coverity points out that addr.len was potentially being used
uninitialized, via calls to in46a_inc(&addr).

Change-Id: Idb67394e5f4c2072380a33f46c848d92c4317245
Related: CID#174189
---
M lib/ippool.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/lib/ippool.c b/lib/ippool.c
index 36121ee..6f3d06e 100644
--- a/lib/ippool.c
+++ b/lib/ippool.c
@@ -202,7 +202,7 @@
 	/* Parse only first instance of pool for now */
 
 	int i;
-	struct in46_addr addr;
+	struct in46_addr addr = { 0 };
 	size_t addrprefixlen;
 	struct in46_addr stataddr;
 	size_t stataddrprefixlen;

-- 
To view, visit https://gerrit.osmocom.org/11869
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb67394e5f4c2072380a33f46c848d92c4317245
Gerrit-Change-Number: 11869
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/21dce413/attachment.html>


More information about the gerrit-log mailing list