Change in libosmocore[master]: LCLS: add GCR routines

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 21 17:17:01 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11827 )

Change subject: LCLS: add GCR routines
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/11827/7/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/11827/7/tests/gsm0808/gsm0808_test.c@137
PS7, Line 137: 	struct gsm0808_gcr g = { .net_len = 3, .node = 0xDEAD }, p = { 0 };
> (BTW, just writing '{}' is identical to '{ 0 }' and it also works with all other structs and arrays  […]
Be careful, iirc I had to fix some struct iniitalizer from {} to {0} in osmocom code once because some gcc versions fail to build that.



-- 
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 7
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Nov 2018 17:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181121/f8cbfa5f/attachment.html>


More information about the gerrit-log mailing list