Change in osmo-bsc[master]: ipaccess-config: cosmetic: Remove unneeded comment with hex values

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 21 13:26:39 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11688 )

Change subject: ipaccess-config: cosmetic: Remove unneeded comment with hex values
......................................................................

ipaccess-config: cosmetic: Remove unneeded comment with hex values

Same type of message parsing is already implemented in code, no need to
keep them.

Related: OS#3624
Change-Id: I715bd9582f9289b5674aaa8d8de1164ebef2fd11
---
M src/ipaccess/ipaccess-config.c
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c
index 9e3dc39..dcaa756 100644
--- a/src/ipaccess/ipaccess-config.c
+++ b/src/ipaccess/ipaccess-config.c
@@ -78,11 +78,6 @@
 static struct abis_nm_sw_desc *sw_load1 = NULL;
 static struct abis_nm_sw_desc *sw_load2 = NULL;
 
-/*
-static uint8_t prim_oml_attr[] = { 0x95, 0x00, 7, 0x88, 192, 168, 100, 11, 0x00, 0x00 };
-static uint8_t unit_id_attr[] = { 0x91, 0x00, 9, '2', '3', '4', '2', '/' , '0', '/', '0', 0x00 };
-*/
-
 extern int ipaccess_fd_cb(struct osmo_fd *bfd, unsigned int what);
 extern struct e1inp_line_ops ipaccess_e1inp_line_ops;
 

-- 
To view, visit https://gerrit.osmocom.org/11688
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I715bd9582f9289b5674aaa8d8de1164ebef2fd11
Gerrit-Change-Number: 11688
Gerrit-PatchSet: 8
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181121/675ebd5a/attachment.html>


More information about the gerrit-log mailing list