This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP ...................................................................... abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. ipaccess-config tool will use this signal in later patch Change-Id Ida416a969a3309868d6f4e50f34b34f224c32dd6. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h index 1b351aa..62a3d2c 100644 --- a/include/osmocom/bsc/signal.h +++ b/include/osmocom/bsc/signal.h @@ -72,6 +72,7 @@ S_NM_STATECHG_ADM, /* Administrative State changed */ S_NM_OM2K_CONF_RES, /* OM2K Configuration Result */ S_NM_OPSTART_ACK, /* Received OPSTART ACK, arg is struct msgb *oml_msg */ + S_NM_GET_ATTR_REP, /* Received Get Attributes Response, arg is struct msgb *oml_msg */ }; /* SS_LCHAN signals */ diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index c1a26ac..f1306fc 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -616,6 +616,7 @@ struct e1inp_sign_link *sign_link = mb->dst; struct gsm_bts *bts = trx ? trx->bts : sign_link->trx->bts; struct tlv_parsed tp; + int rc; DEBUGPFOH(DNM, foh, "Get Attributes Response for BTS%u\n", bts->nr); @@ -623,9 +624,13 @@ /* nanoBTS doesn't send Get Attribute Response Info, uses its own format */ if (bts->type != GSM_BTS_TYPE_NANOBTS) - return parse_attr_resp_info(bts, trx, foh, &tp); + rc = parse_attr_resp_info(bts, trx, foh, &tp); else - return parse_attr_resp_info_attr(bts, trx, foh, &tp); + rc = parse_attr_resp_info_attr(bts, trx, foh, &tp); + + osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb); + + return rc; } /* 3GPP TS 52.021 §6.2.5 */ -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 6 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181121/8a593cd8/attachment.htm>