Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11790 )

Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn
......................................................................

bsc: band_compatible: Return band non-compatible for invalid arfcn

Before libosmocore Change-Id I780d452dcebce385469e32ef2fd844df6033393a,
it avoids stating arfcn 886-954 are compatible when operating under
DC1800. After that Change-Id, avoids aborting the program due to
unexpected behaviour.

Related: OS#3063
Depends: libosmocore Change-Id I780d452dcebce385469e32ef2fd844df6033393a
Change-Id: Ibf5d5ab50b6fc6597244eeedcd27d2ce245278a3
---
M src/osmo-bsc/system_information.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c
index 0a441dc..4709f7f 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -53,7 +53,12 @@
  */
 static int band_compatible(const struct gsm_bts *bts, int arfcn)
 {
-	enum gsm_band band = gsm_arfcn2band(arfcn);
+	enum gsm_band band;
+
+	if (gsm_arfcn2band_rc(arfcn, &band) < 0) {
+		LOGP(DRR, LOGL_ERROR, "Invalid arfcn %d detected!\n", arfcn);
+		return 0;
+	}
 
 	/* normal case */
 	if (band == bts->band)

-- 
To view, visit https://gerrit.osmocom.org/11790
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5d5ab50b6fc6597244eeedcd27d2ce245278a3
Gerrit-Change-Number: 11790
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/438cabe5/attachment.htm>