Change in osmo-gsm-manuals[master]: Makefile.*.inc: adjust to out-of-tree building

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 20 17:44:26 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11803 )

Change subject: Makefile.*.inc: adjust to out-of-tree building
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc
File build/Makefile.asciidoc.inc:

https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc@63
PS3, Line 63: 	# $(notdir) is like basename from coreutils, and $PWD is the $(builddir).
where is $PWD used here?



-- 
To view, visit https://gerrit.osmocom.org/11803
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b212a6518f0fc29fae610a37ae6c533189278d
Gerrit-Change-Number: 11803
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Nov 2018 17:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/0a3367c3/attachment.html>


More information about the gerrit-log mailing list