Change in osmo-gsm-manuals[master]: *filter.conf/*.sty: use symlinks to build, common

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 20 16:14:14 UTC 2018


Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/11798

to look at the new patch set (#2).

Change subject: *filter.conf/*.sty: use symlinks to build, common
......................................................................

*filter.conf/*.sty: use symlinks to build, common

$(OSMO_GSM_MANUALS_DIR) is used in most places to reference to the top
dir, which contains "build" and "common". But not in the asciidoc
mscgen filter configurations, and in the custom LaTeX style. They have
../common or ../build hardcoded, which won't work anymore when the
project specific files will be in another repository.

Update the Makefiles to create symlinks to "build" and "common" in the
dir where the build was started. Use ./common in the files that had
../common hardcoded, and do the same for ./build.

Update the Makefile.common.inc comment to refer to common targets in
general, so we don't need to list each single one there (like the new
'common' and 'build' targets).

I've also thought about using variables there, but this would only work
for the asciidoc files, not for the .sty file. We would need to
generate the latter from another file and replace the variable
dynamically. Having the symlinks instead seemed to be slightly easier.

(moving manuals to project repositories 7/19)

Related: OS#3385
Change-Id: I4cfd1a9ef482d382f10cdf060e8e2cba81852864
---
M .gitignore
M build/Makefile.asciidoc.inc
M build/Makefile.common.inc
M build/Makefile.docbook.inc
M build/custom-dblatex.sty
M build/mscgen-filter.conf
M build/python2-filter.conf
7 files changed, 25 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/98/11798/2
-- 
To view, visit https://gerrit.osmocom.org/11798
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cfd1a9ef482d382f10cdf060e8e2cba81852864
Gerrit-Change-Number: 11798
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/a60d8ed0/attachment.html>


More information about the gerrit-log mailing list