Change in osmo-msc[master]: Use BSSAP-specific TLV parser from libosmocore

Max gerrit-no-reply at lists.osmocom.org
Tue Nov 20 15:24:54 UTC 2018


Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11831 )

Change subject: Use BSSAP-specific TLV parser from libosmocore
......................................................................

Use BSSAP-specific TLV parser from libosmocore

Change-Id: Iae1a3ffcebf1b0b95e61cd5dffe7ef734796fcfc
---
M src/libmsc/a_iface_bssap.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index 282fd73..f24fb05 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -611,7 +611,7 @@
 	}
 	msg_type = msg->l3h[0];
 
-	rc = tlv_parse(&tp, gsm0808_att_tlvdef(), msg->l3h + 1, msgb_l3len(msg) - 1, 0, 0);
+	rc = osmo_bssap_tlv_parse(&tp, msg->l3h + 1, msgb_l3len(msg) - 1);
 	if (rc < 0) {
 		LOGP(DBSSAP, LOGL_ERROR, "Failed parsing TLV -- discarding message! %s\n",
 			osmo_hexdump(msg->l3h, msgb_l3len(msg)));

-- 
To view, visit https://gerrit.osmocom.org/11831
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1a3ffcebf1b0b95e61cd5dffe7ef734796fcfc
Gerrit-Change-Number: 11831
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/1a427242/attachment.html>


More information about the gerrit-log mailing list