This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11838 ) Change subject: Fix IMSI padding in imsi-acl ...................................................................... Patch Set 1: Code-Review-1 (1 comment) BTW, are you sure only first byte is initialized and not the whole array? Did you check it by testing or using gdb? https://gerrit.osmocom.org/#/c/11838/1/src/gprs/sgsn_vty.c File src/gprs/sgsn_vty.c: https://gerrit.osmocom.org/#/c/11838/1/src/gprs/sgsn_vty.c@637 PS1, Line 637: char imsi_sanitized[GSM23003_IMSI_MAX_DIGITS + 1] = { [0 ... GSM23003_IMSI_MAX_DIGITS] = '0' }; I bet this is close to zero portable. Can we find some other way of initializing it, like memset() ? char imsi_sanitized[GSM23003_IMSI_MAX_DIGITS + 1]; memset(imti_sanitized, '0', GSM23003_IMSI_MAX_DIGITS); "This is a GNU extension of C99 Designated Initializers. In older GCC, you may need to use -std=gnu99 to compile your code." https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html "To initialize a range of elements to the same value, write ‘[first ... last] = value’. This is a GNU extension." -- To view, visit https://gerrit.osmocom.org/11838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e4aa44f159d1b5b91dda4a586fd4e809711245 Gerrit-Change-Number: 11838 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Nov 2018 09:59:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/011b0f49/attachment.htm>