Change in osmo-gsm-manuals[master]: Makefile.*.inc: adjust to out-of-tree building

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 20 02:14:15 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11803 )

Change subject: Makefile.*.inc: adjust to out-of-tree building
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

(this is a -0.5)

https://gerrit.osmocom.org/#/c/11803/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11803/1//COMMIT_MSG@18
PS1, Line 18: the xstl parser, as well as the LaTeX compiler, so they can find the
is that the "TEXINPUTS" bit?


https://gerrit.osmocom.org/#/c/11803/1/build/Makefile.asciidoc.inc
File build/Makefile.asciidoc.inc:

https://gerrit.osmocom.org/#/c/11803/1/build/Makefile.asciidoc.inc@60
PS1, Line 60: 	[ -f $(notdir $<) ] || ln -s $< $(notdir $<)
if you keep using this '[ ... ] ||' syntax you might run into the danger of me getting used to it and not complaining about it anymore. Isn't 'if [ condition ]; then ... fi' much more readable?

ok, wait, I don't get what this is doing at all. '$<' ... the input file, so the .adoc file? and '$(notdir)'??
ah, essentially notdir == basename.

so this creates a symlink where, in the $builddir, pointing at the $srcdir?

this took long enough to warrant a comment:

# Create a symlink at $(builddir)/srcfile.adoc pointing at $(srcdir)/srcfile.adoc.
# $< is the $(srcdir)/srcfile.adoc, $(notdir) is like basename, and $PWD is the $(builddir).


https://gerrit.osmocom.org/#/c/11803/1/build/Makefile.asciidoc.inc@66
PS1, Line 66: 	TEXINPUTS="$(OSMO_GSM_MANUALS_DIR)" \
add comment: "pass TEXINPUTS to help a2x find [...]" (insert files to find)



-- 
To view, visit https://gerrit.osmocom.org/11803
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b212a6518f0fc29fae610a37ae6c533189278d
Gerrit-Change-Number: 11803
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Nov 2018 02:14:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/6df79cd5/attachment.htm>


More information about the gerrit-log mailing list