Change in libosmocore[master]: LCLS: add GCR routines

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11827 )

Change subject: LCLS: add GCR routines
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/11827/4/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

https://gerrit.osmocom.org/#/c/11827/4/include/osmocom/gsm/gsm0808_utils.h@71
PS4, Line 71: 	uint8_t *net;    /* Network ID, ITU-T Q.1902.3 */
Same, here, why not using net[5]?


https://gerrit.osmocom.org/#/c/11827/4/include/osmocom/gsm/gsm0808_utils.h@74
PS4, Line 74: 	uint8_t *cr;     /* Call Reference ID (5 octets) */
if it's 5 octets, why not using uint8_t cr[5] ?


https://gerrit.osmocom.org/#/c/11827/4/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/11827/4/src/gsm/gsm0808.c@416
PS4, Line 416: 	if (!msg || !g)
if g==NULL and alloc works --> memory leak.

No need to check for !g, just remove it, I think we can assume we don't pass NULL to it since it makes no sense.


https://gerrit.osmocom.org/#/c/11827/4/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/11827/4/tests/gsm0808/gsm0808_test.c@138
PS4, Line 138: 	uint8_t net[g.net_len], pnet[g.net_len], cr[5], pcr[5] = { 0 };
See? no need for all this, just define arrays in the struct instead of pointers.



-- 
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Nov 2018 17:39:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/51495ada/attachment.htm>