Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Nov 19 16:51:27 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11789 )

Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc
......................................................................


Patch Set 1:

Hi,

 > I could change the commit to name the new API
 > "gsm_arfcn2band_validate", or actually use
 > "osmo_gsm_arfcn2band".

A possible way to go is to introduce the new osmo_gsm_arfcn2band(),
introduce GSM_BAND_INVAL = 0x00, and return GSM_BAND_INVAL for 'out
of band' values from there.

The old gsm_arfcn2band() could then just call osmo_gsm_arfcn2band(),
and replace GSM_BAND_INVAL by GSM_BAND_1800. And of course, it would
be marked as deprecated. What do you think?


-- 
To view, visit https://gerrit.osmocom.org/11789
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I780d452dcebce385469e32ef2fd844df6033393a
Gerrit-Change-Number: 11789
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Nov 2018 16:51:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/5a055a82/attachment.htm>


More information about the gerrit-log mailing list