Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 19 14:56:21 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11832 )

Change subject: Use libosmocore to function to parse cipher mode reject cause
......................................................................


Patch Set 1: -Code-Review

(2 comments)

https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c@436
PS1, Line 436: 	if (!TLVP_PRES_LEN(tp, GSM0808_IE_CAUSE, 1)) {
BTW, is this required now that gsm0808_get_cipher_reject_cause is used? I guess it's not.


https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c@448
PS1, Line 448: 	rate_ctr_inc(&msc->ctr[MSC_CTR_BSSMAP_CIPHER_MODE_REJECT]);
> It should count the number of valid CMR messages that's why it's after the error handling. […]
Do we count "broken" CMR messages in some place? I don't see this counter being called "MSC_CTR_BSSMAP_CIPHER_MODE_REJECT_VALID", so I expect all of them are counted, irrespective of whether they contain a correct cause code or not.



-- 
To view, visit https://gerrit.osmocom.org/11832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7742ac41dd0642a5a40ce79d23250f8d9e6ae556
Gerrit-Change-Number: 11832
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Nov 2018 14:56:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/b861c552/attachment.html>


More information about the gerrit-log mailing list