Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 19 14:45:24 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/11832 )

Change subject: Use libosmocore to function to parse cipher mode reject cause
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c@448
PS1, Line 448: 	rate_ctr_inc(&msc->ctr[MSC_CTR_BSSMAP_CIPHER_MODE_REJECT]);
> ctr_inc should go at the start of the function imho, after first LOGPCONN. […]
It should count the number of valid CMR messages that's why it's after the error handling. Having it in the beginning would defeat the purpose of having this counter in a first place: we would be unable to distinguish between proper and broken CMR messages in TTCN tests.



-- 
To view, visit https://gerrit.osmocom.org/11832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7742ac41dd0642a5a40ce79d23250f8d9e6ae556
Gerrit-Change-Number: 11832
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Nov 2018 14:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/7627506d/attachment.html>


More information about the gerrit-log mailing list