Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 19 14:15:14 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11832 )

Change subject: Use libosmocore to function to parse cipher mode reject cause
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/11832/1/src/libmsc/a_iface_bssap.c@448
PS1, Line 448: 	rate_ctr_inc(&msc->ctr[MSC_CTR_BSSMAP_CIPHER_MODE_REJECT]);
ctr_inc should go at the start of the function imho, after first LOGPCONN. At least don't put it even lower than it was.



-- 
To view, visit https://gerrit.osmocom.org/11832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7742ac41dd0642a5a40ce79d23250f8d9e6ae556
Gerrit-Change-Number: 11832
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Nov 2018 14:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/20389e0f/attachment.html>


More information about the gerrit-log mailing list