Change in osmo-bsc[master]: don't remove socket path in rf_create_socket()

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Nov 19 11:41:54 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11782 )

Change subject: don't remove socket path in rf_create_socket()
......................................................................


Patch Set 4:

> Patch Set 4:
> 
> How do tests fail? Why not fixing the tests instead of removing unlink()?

OK I have figured out what the test is doing.

The problem is that unlink fails if the socket path does not yet exist.
So we will probably need to catch ENOENT and ignore it.

stsp at fintan:~/osmo/osmo-bsc$ osmo-bsc -r tmp_dummy_sock -c doc/examples/osmo-bsc/osmo-bsc.cfg 
logging level cc (debug|info|notice|error|fatal)
logging level mgcp (debug|info|notice|error|fatal)
% dyn_ts_allow_tch_f is deprecated, rather use msc/codec-list to pick codecs
T3212 = 5 * 6min (Periodic Location Update timer, sent to MS (1 = 6 minutes))
<0013> telnet_interface.c:104 Available via telnet 127.0.0.1 4242
<0015> input/ipaccess.c:844 enabling ipaccess BSC mode on 0.0.0.0 with OML 3002 and RSL 3003 TCP ports
<001a> control_if.c:911 CTRL at 127.0.0.1 4249
<0015> bsc_rf_ctrl.c:460 Could not unlink socket path tmp_dummy_sock: 2/No such file or directory
Failed to create the RF service.


-- 
To view, visit https://gerrit.osmocom.org/11782
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c873da305cbb47aef0562f61ec21057363f294
Gerrit-Change-Number: 11782
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Nov 2018 11:41:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/c5bcf13e/attachment.html>


More information about the gerrit-log mailing list