This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11783 ) Change subject: add missing check of osmo_wqueue_enqueue() return value ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11783/1/src/osmo-bts-sysmo/l1_if.c File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/#/c/11783/1/src/osmo-bts-sysmo/l1_if.c@555 PS1, Line 555: return -ENOBUFS; > IMHO doesn't make much sense to use -EAGAIN while freeing the parameter passed from caller (msg). […] I agree, thanks. Fixed in next patch set. For what it's worth: I used EAGAIN because EAGAIN is already used by another caller of osmo_wqueue_enqueue() on failure; see l1if_set_trace_flags(). -- To view, visit https://gerrit.osmocom.org/11783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5671ca364f31d98f2b28d028e7bf1797386de2ec Gerrit-Change-Number: 11783 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Nov 2018 11:23:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/f6f3c85e/attachment.htm>