Change in osmo-bts[master]: properly initialize si3 in test_is_ccch_for_agch_setup()

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Nov 19 11:10:37 UTC 2018


Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11784 )

Change subject: properly initialize si3 in test_is_ccch_for_agch_setup()
......................................................................

properly initialize si3 in test_is_ccch_for_agch_setup()

Prevent potential use of uninitialized memory in paging test.

Change-Id: Ie8f8fc3c4a9e4cc18fc85b6822110de79da4246b
Related: CID#188828
---
M tests/paging/paging_test.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/paging/paging_test.c b/tests/paging/paging_test.c
index 18708e2..f112404 100644
--- a/tests/paging/paging_test.c
+++ b/tests/paging/paging_test.c
@@ -116,7 +116,7 @@
 {
 	static struct gsm_bts_trx trx;
 	static struct gsm_bts bts;
-	struct gsm48_system_information_type_3 si3;
+	struct gsm48_system_information_type_3 si3 = { 0 };
 	si3.control_channel_desc.bs_ag_blks_res = bs_ag_blks_res;
 	trx.bts = &bts;
 	bts.si_valid |= 0x8;

-- 
To view, visit https://gerrit.osmocom.org/11784
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8f8fc3c4a9e4cc18fc85b6822110de79da4246b
Gerrit-Change-Number: 11784
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/271dbbb2/attachment.html>


More information about the gerrit-log mailing list