Change in osmo-gsm-manuals[master]: use autotools to add "make install" target

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 16 16:33:56 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11725 )

Change subject: use autotools to add "make install" target
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/11725/5/configure.ac
File configure.ac:

https://gerrit.osmocom.org/#/c/11725/5/configure.ac@22
PS5, Line 22: if ! $srcdir/check-depends.sh
I think this should be builddir instead, and make sure check-depends.sh is added to EXTRA_DIST. Because we want to support make distcheck, right?



-- 
To view, visit https://gerrit.osmocom.org/11725
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e7036fae062ee783cb132b14608827a82c5e7c7
Gerrit-Change-Number: 11725
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Nov 2018 16:33:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181116/8464a1b0/attachment.html>


More information about the gerrit-log mailing list