Change in osmo-bts[master]: add missing check of osmo_wqueue_enqueue() return value

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 16 15:50:22 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11783 )

Change subject: add missing check of osmo_wqueue_enqueue() return value
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11783/1/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:

https://gerrit.osmocom.org/#/c/11783/1/src/osmo-bts-sysmo/l1_if.c@555
PS1, Line 555: 		return -EAGAIN;
IMHO doesn't make much sense to use -EAGAIN while freeing the parameter passed from caller (msg).

What about returning -ENOBUFS ?



-- 
To view, visit https://gerrit.osmocom.org/11783
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5671ca364f31d98f2b28d028e7bf1797386de2ec
Gerrit-Change-Number: 11783
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Nov 2018 15:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181116/e9f49e2c/attachment.html>


More information about the gerrit-log mailing list