Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Nov 16 14:12:06 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11792 )

Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Looks fine, only one cosmetic issue though.

https://gerrit.osmocom.org/#/c/11792/3/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/#/c/11792/3/src/libmsc/gsm_04_11.c@690
PS3, Line 690:      
Let's please avoid mixing tabs and spaces when it's not required.
I recommend either use a tab here, or not to wrap the line at all.



-- 
To view, visit https://gerrit.osmocom.org/11792
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be
Gerrit-Change-Number: 11792
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 14:12:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181116/cb0b3ac4/attachment.htm>


More information about the gerrit-log mailing list