Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Fri Nov 16 13:52:58 UTC 2018


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/11792

to look at the new patch set (#3).

Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.
......................................................................

libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

When using smpp-first, after the ESME accepts our STATUS REPORT,
we were sending it locally into gsm340_rx_sms_submit() anyway.
In the case of the ESME mirroring the report back to us, this
would result in two copies of the status report in the SMS
database, which were also both then delivered to the MS.
This causes no visible error to the user but is a waste of radio
resources.

With this patch, we check if it is the sms_report that has had 
receiver set in sms_route_mt_sms() and not the original SMS we
are reporting on, which of course already has receiver set.

Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be
---
M src/libmsc/gsm_04_11.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/11792/3
-- 
To view, visit https://gerrit.osmocom.org/11792
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be
Gerrit-Change-Number: 11792
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181116/27cfb1ea/attachment.html>


More information about the gerrit-log mailing list