Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Nov 15 16:06:44 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11782 )

Change subject: unlink socket path correctly in rf_create_socket()
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1: Code-Review-1
> 
> (1 comment)

Good i

https://gerrit.osmocom.org/#/c/11782/1/src/osmo-bsc/bsc_rf_ctrl.c
File src/osmo-bsc/bsc_rf_ctrl.c:

https://gerrit.osmocom.org/#/c/11782/1/src/osmo-bsc/bsc_rf_ctrl.c@459
PS1, Line 459: 		LOGP(DLINP, LOGL_ERROR, "Could not unlink socket path %s: errno: %d/%s\n",
> Please print errno or rc or whatever gives more information here.
Good idea. See next patch set. It now logs the error in the same way as done elsewhere in this function.



-- 
To view, visit https://gerrit.osmocom.org/11782
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c873da305cbb47aef0562f61ec21057363f294
Gerrit-Change-Number: 11782
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Nov 2018 16:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181115/8a5bea5f/attachment.htm>


More information about the gerrit-log mailing list