Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 14 16:24:44 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11742 )

Change subject: coverity: gscon_forget_lchan: squelch forward-null
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11742/1/src/osmo-bsc/bsc_subscr_conn_fsm.c
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/#/c/11742/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@655
PS1, Line 655: 	if (!conn || !conn->fi)
> Do we really then need this check at all if they are allocated and removed at the same time? "if (!c […]
Right, if no code checks conn->fi then coverity won't see a problem.



-- 
To view, visit https://gerrit.osmocom.org/11742
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62354aa998832131c86535f39a29294000114adc
Gerrit-Change-Number: 11742
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Nov 2018 16:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181114/a2d96878/attachment.htm>


More information about the gerrit-log mailing list