Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 14 16:13:45 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11668 )

Change subject: cosmetic: lchan: introduce sub-struct lchan->release.*
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@518
PS1, Line 518: 		bool release_requested;
> I considered the same, but in the end decided that a variable name of "requested" is a bit weird. […]
I think code is cleaner if we remove the release_ prefix, indeed.



-- 
To view, visit https://gerrit.osmocom.org/11668
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfddc6010e5d7c309f1a7ed3526b5b635ffeaf11
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Nov 2018 16:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181114/1f7ab0e9/attachment.html>


More information about the gerrit-log mailing list