Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 13 12:37:46 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 )

Change subject: unix-time-to-fmt.py: fix crash without argument
......................................................................


Patch Set 1:

> In that case the best would be to store the date into the tarball like we do with "./git-version-gen .tarball-version", then take it from there if git repo is not available.
>
> Please note I'm not against this patch, I'm just saying other fixes may also provide better results. We can still merge this one.

Yes, it makes sense to do this in the future.

> (leaving to Pau to CR)

Pau, would you like to add the +2?


-- 
To view, visit https://gerrit.osmocom.org/11724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba27cc23543e47cc8a1e494c35cc33f1dc8f297
Gerrit-Change-Number: 11724
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Nov 2018 12:37:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181113/0d976edd/attachment.html>


More information about the gerrit-log mailing list