Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Nov 13 10:31:54 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11730 )

Change subject: fix bogus error check in gprs_sndcp_comp_create()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11730/1/src/gprs/gprs_sndcp_comp.c
File src/gprs/gprs_sndcp_comp.c:

https://gerrit.osmocom.org/#/c/11730/1/src/gprs/gprs_sndcp_comp.c@106
PS1, Line 106: 	} else {
> I see there's too SNDCP_XID_VERSION_NUMBER. What about it? […]
VERSION_NUMBER is only used later, when the packet is encoded by gprs_sndcp_compile_xid().
So if we encounter it here, it is invalid.

The next patch in this series (https://gerrit.osmocom.org/c/osmo-sgsn/+/11656/) transforms this if-else statement into a switch statement.



-- 
To view, visit https://gerrit.osmocom.org/11730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8444c1ed052707c76a979fb06cb018ac678defa7
Gerrit-Change-Number: 11730
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Nov 2018 10:31:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181113/4c6a4f49/attachment.html>


More information about the gerrit-log mailing list