Change in osmo-msc[master]: move project specific manuals to their own repos

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 12 17:54:31 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11726 )

Change subject: move project specific manuals to their own repos
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

I associate 'man' with the unix manpages. IIUC we are generating / going to generate manpages from this, but IMHO this should be called 'manuals'; or rather, just be directly in the doc/ dir, after all, "documentation / manuals" is redundant.

https://gerrit.osmocom.org/#/c/11726/1/.gitignore
File .gitignore:

https://gerrit.osmocom.org/#/c/11726/1/.gitignore@66
PS1, Line 66: *.html
Seems that the manuals get generated in the root dir of the {source,build} tree? I would prefer a subdir


https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc
File doc/man/chapters/counters_generated.adoc:

https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc@6
PS1, Line 6: .msc - mobile switching center 
whitespace


https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc@37
PS1, Line 37: | msc.active_calls | <<ungroup_counter_msc.active_calls>> | 
whitespace



-- 
To view, visit https://gerrit.osmocom.org/11726
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7
Gerrit-Change-Number: 11726
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Nov 2018 17:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/80eef5c0/attachment.html>


More information about the gerrit-log mailing list