Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Mon Nov 12 17:45:49 UTC 2018


Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11716 )

Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
......................................................................

Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

Allows dialing of numbers with GSM340_PLAN_UNKNOWN,
for example a number beginning with '*'

Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
---
M src/mncc.c
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/mncc.c b/src/mncc.c
index 976a671..ea6a9fc 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -397,14 +397,16 @@
 
 static int continue_setup(struct mncc_connection *conn, const struct gsm_mncc *mncc)
 {
-	if (mncc->called.plan != GSM340_PLAN_ISDN) {
+	switch (mncc->called.plan) {
+	case GSM340_PLAN_UNKNOWN:
+	case GSM340_PLAN_ISDN:
+		return 1;
+	default:
 		LOGP(DMNCC, LOGL_ERROR,
-			"leg(%u) has non(%d) ISDN dial plan. not supported.\n",
+			"leg(%u) has unsupported(%d) dial plan.\n",
 			mncc->callref, mncc->called.plan);
 		return 0;
 	}
-
-	return 1;
 }
 
 /* Check + Process MNCC_SETUP_IND (MO call) */

-- 
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/8e58dcac/attachment.html>


More information about the gerrit-log mailing list