Change in osmo-msc[master]: vlr: use unused is_ps parameter in vlr_subscr_req_lu()

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 12 17:27:34 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11563 )

Change subject: vlr: use unused is_ps parameter in vlr_subscr_req_lu()
......................................................................


Patch Set 1: Code-Review-1

let's rather drop the argument and always use vlr->cfg.is_ps directly. There is no situation where these could possibly differ.


-- 
To view, visit https://gerrit.osmocom.org/11563
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfc925f2cb254d192e86568958b5ecb68fac09da
Gerrit-Change-Number: 11563
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 17:27:34 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/e7bc1c56/attachment.html>


More information about the gerrit-log mailing list