Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Nov 12 13:43:29 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11716 )

Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@401
PS2, Line 401: case
The 'case' statements are usually not shifted from 'switch', i.e.:

  switch (var) {
  case VAL_FOO:
    tuwat_foo;
    break;
  case VAL_ZOO:
    tuwat_zoo;
    break;
  // ...
  }


https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@406
PS2, Line 406: 			    "leg(%u) has unsupported(%d) dial plan.\n",
> We usually indent next lines to content, not to the "(" character, so it looks like a space is missi […]
Actually, in this file a single tab is used for that.
I personally prefer exactly this way, instead of mixing
tabs and spaces in order to make it aligned...



-- 
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 13:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/6f58353d/attachment.html>


More information about the gerrit-log mailing list