Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 12 11:12:15 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 )

Change subject: unix-time-to-fmt.py: fix crash without argument
......................................................................


Patch Set 1: Code-Review+1

> > What about fixing the Makefile lines to include -C or whatever
 > when calling git to point to correct directory?
 > 
 > That would work. Is there always a git directory though? I'm
 > thinking about users downloading tarballs and running the build
 > system from there.

In that case the best would be to store the date into the tarball like we do with "./git-version-gen .tarball-version", then take it from there if git repo is not available.

Please note I'm not against this patch, I'm just saying other fixes may also provide better results. We can still merge this one.


-- 
To view, visit https://gerrit.osmocom.org/11724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba27cc23543e47cc8a1e494c35cc33f1dc8f297
Gerrit-Change-Number: 11724
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Nov 2018 11:12:15 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/d91066a9/attachment.htm>


More information about the gerrit-log mailing list