Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

osmith gerrit-no-reply at lists.osmocom.org
Mon Nov 12 10:40:59 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/11722 )

Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11722/1/build/Makefile.asciidoc.inc
File build/Makefile.asciidoc.inc:

https://gerrit.osmocom.org/#/c/11722/1/build/Makefile.asciidoc.inc@61
PS1, Line 61: 		asciidoc -v $(ASCIIDOC_OPTS) $<; exit 1)
> isn't this exit 1 applied only to the subshell created by parenthesis? or parenthesis don't create a […]
They do create a subshell, but the subshell's exit code is the exit code of the last program it ran (exit 1 in this case). So the overall exit code is 1.

This can be reproduced on Debian by *not* installing asciidoc-latex: a2x will fail, but asciidoc will pass unless the exit1 is added like in this commit.



-- 
To view, visit https://gerrit.osmocom.org/11722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30931303ecc6094efaedcb08380433a34211a169
Gerrit-Change-Number: 11722
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Nov 2018 10:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/c578332f/attachment.html>


More information about the gerrit-log mailing list