Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

osmith gerrit-no-reply at lists.osmocom.org
Mon Nov 12 10:40:32 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 )

Change subject: unix-time-to-fmt.py: fix crash without argument
......................................................................


Patch Set 1:

> Where is it called without arguments and why?

https://git.osmocom.org/osmo-gsm-manuals/tree/build/Makefile.asciidoc.inc?id=c3db2aadbfea749d4d10f56722d6113474091ee6#n20

Here, it gets called without arguments when the git command fails.

> Why is this needed?

I ran into this when building the osmo-msc manuals out-of-tree (with the other related patches applied). It prints the Python stack trace during the build process, which does not stop the build, but is confusing.

> Wouldn't it make more sense to take now() as date or 0? No idea, just asking as I lack context here.

I would not set it to the current date, otherwise old manual pages can end up with a newer date.


-- 
To view, visit https://gerrit.osmocom.org/11724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba27cc23543e47cc8a1e494c35cc33f1dc8f297
Gerrit-Change-Number: 11724
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Nov 2018 10:40:32 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/b121cbca/attachment.html>


More information about the gerrit-log mailing list