Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Nov 12 10:21:33 UTC 2018


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11722


Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error
......................................................................

Makefile.asciidoc.inc: always exit 1 on a2x error

a2x wraps asciidoc. When a2x fails, we run asciidoc without a2x to
print verbose output. Make sure that 'make' fails at this point, even
if asciidoc runs through.

Change-Id: I30931303ecc6094efaedcb08380433a34211a169
---
M build/Makefile.asciidoc.inc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/22/11722/1

diff --git a/build/Makefile.asciidoc.inc b/build/Makefile.asciidoc.inc
index a28a5bb..ee7a60d 100644
--- a/build/Makefile.asciidoc.inc
+++ b/build/Makefile.asciidoc.inc
@@ -57,7 +57,8 @@
 	  NOTE: TO REMOVE DRAFT MODE, YOU NEED TO EDIT build/custom-dblatex.sty\n\
 	        and remove three lines starting with '% \"DRAFT\" on first page'\n" \
 	  || true
-	a2x $(A2X_OPTS) $< || asciidoc -v $(ASCIIDOC_OPTS) $<
+	a2x $(A2X_OPTS) $< || (echo "ERROR: a2x failed! Running asciidoc to get verbose errors..."; \
+		asciidoc -v $(ASCIIDOC_OPTS) $<; exit 1)
 
 check: $(ASCIIDOC_CHECKS)
 

-- 
To view, visit https://gerrit.osmocom.org/11722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30931303ecc6094efaedcb08380433a34211a169
Gerrit-Change-Number: 11722
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/884dd39a/attachment.htm>


More information about the gerrit-log mailing list