Change in libosmo-sccp[master]: SS7: safeguard against wrong number of pointcode component

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 12 10:00:17 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11707 )

Change subject: SS7: safeguard against wrong number of pointcode component
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

This function is static and so only used here. Please change the function to return an int, document it accordingly and change users to check for error if needed.

https://gerrit.osmocom.org/#/c/11707/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11707/1//COMMIT_MSG@10
PS1, Line 10: code when called with wrong component number despite unsinged return
typo: unsigned



-- 
To view, visit https://gerrit.osmocom.org/11707
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib24cdbcf614bad68f3cfa9776a451c5c1e45ae6e
Gerrit-Change-Number: 11707
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Nov 2018 10:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/0bc3392e/attachment.html>


More information about the gerrit-log mailing list