Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Sun Nov 11 23:21:47 UTC 2018


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11716 )

Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400
PS1, Line 400: 	if (mncc->called.plan != GSM340_PLAN_UNKNOWN && mncc->called.plan != GSM340_PLAN_ISDN) {
> Maybe, using a switch statement would be better here?
It could also be a > greater than (1==GSM340_PLAN_ISDN) test.
I don't know. - I don't anticipate ever handling other cases.



-- 
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 11 Nov 2018 23:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181111/e7227787/attachment.html>


More information about the gerrit-log mailing list