Change in osmo-bsc[master]: lchan_fsm_cleanup: drop redundant 'forget_lchan' call

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Nov 10 06:48:45 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11713 )

Change subject: lchan_fsm_cleanup: drop redundant 'forget_lchan' call
......................................................................

lchan_fsm_cleanup: drop redundant 'forget_lchan' call

Right below this call, we invoke lchan_reset(), and the first thing it does is
gscon_forget_lchan(). Drop this redundant invocation.

Change-Id: I503efceb6d34c8df0cdfef3dfc83fa1e61271c47
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 915b62a..0046f59 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1343,8 +1343,6 @@
 void lchan_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause)
 {
 	struct gsm_lchan *lchan = lchan_fi_lchan(fi);
-	if (lchan->conn)
-		gscon_forget_lchan(lchan->conn, lchan);
 	lchan_reset(lchan);
 	if (lchan->last_error) {
 		talloc_free(lchan->last_error);

-- 
To view, visit https://gerrit.osmocom.org/11713
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I503efceb6d34c8df0cdfef3dfc83fa1e61271c47
Gerrit-Change-Number: 11713
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181110/1d562f35/attachment.html>


More information about the gerrit-log mailing list