Change in libosmo-sccp[master]: return error code from xua_srv_conn_cb() if conn is freed

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Nov 9 14:30:23 UTC 2018


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/11704

to look at the new patch set (#2).

Change subject: return error code from xua_srv_conn_cb() if conn is freed
......................................................................

return error code from xua_srv_conn_cb() if conn is freed

Allow callers of xua_srv_conn_cb() to tell whether conn
was freed by returning error code EBADF, which is also
used elsewhere in osmocom programs for this purpose.

This is necessary because xua_srv_conn_cb(0 might be running
inside of a loop which checks for read and then write events
on the connection. If the connection is freed by xua_srv_conn_cb()
as part of processing a read event, callers should avoid further
processing of events. But if we don't return an error we are leaving
callers none the wiser and with a dangling conn pointer.

Change-Id: I7359667b2f25d6c45acc70049b2a4ee2f376a1df
Related: OS#3685
---
M src/osmo_ss7.c
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/04/11704/2
-- 
To view, visit https://gerrit.osmocom.org/11704
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7359667b2f25d6c45acc70049b2a4ee2f376a1df
Gerrit-Change-Number: 11704
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181109/a1060a72/attachment.html>


More information about the gerrit-log mailing list