Change in osmo-bsc[master]: ipaccess-config: Use stderr for debug type messages when using -G

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 9 13:09:21 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11687 )

Change subject: ipaccess-config: Use stderr for debug type messages when using -G
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

+2 yourself if you're sure

https://gerrit.osmocom.org/#/c/11687/5/src/ipaccess/ipaccess-config.c
File src/ipaccess/ipaccess-config.c:

https://gerrit.osmocom.org/#/c/11687/5/src/ipaccess/ipaccess-config.c@531
PS5, Line 531: 	fprintf(get_attr ? stderr : stdout, "OML link established using TRX %d\n", trx->nr);
IMHO would make more sense to name the global variable 'quiet' or something and completely omit the other output, but ok if you really think this makes sense



-- 
To view, visit https://gerrit.osmocom.org/11687
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I257bfc8d82b49a3641be6b6777e472ecf561a21e
Gerrit-Change-Number: 11687
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Nov 2018 13:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181109/df6f1455/attachment.html>


More information about the gerrit-log mailing list