Change in osmo-bsc[master]: abis_nm: Split attr parsing in Attribute Response Info into its own func

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 9 10:15:35 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11693 )

Change subject: abis_nm: Split attr parsing in Attribute Response Info into its own func
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c@530
PS1, Line 530: 
> what with the 'return data + adjust' stuff before this patch ... […]
It's part of the old functions expecting TLVs in a specific order, that's why it can be removed because all that is wrong an useless.



-- 
To view, visit https://gerrit.osmocom.org/11693
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec7a6e4d27639d0e5adc0d9a01cd3c3e7a46f558
Gerrit-Change-Number: 11693
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Nov 2018 10:15:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181109/641d476d/attachment.html>


More information about the gerrit-log mailing list