This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11684/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/2//COMMIT_MSG@10 PS2, Line 10: and do something with the information. with no-one using it, this patch adds dead code. Either squash the user in here, or refer to a change-id that will add a user. https://gerrit.osmocom.org/#/c/11684/2/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/11684/2/src/osmo-bsc/abis_nm.c@605 PS2, Line 605: osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb); (would it make sense to instead pass the already parsed attributes somehow? Maybe even in a form of msgb->foo pointer ... just thinking) -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 08 Nov 2018 17:09:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/98a35801/attachment.htm>