Change in osmo-bsc[master]: abis_nm: parse_attr_resp_info_unreported: Fix offset calculation

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 8 17:05:23 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11683 )

Change subject: abis_nm: parse_attr_resp_info_unreported: Fix offset calculation
......................................................................


Patch Set 2: Code-Review+1

> Patch Set 1:
> 
> > That's odd - is there some test case which could catch that? Also,
>  > describe in commit message what exactly is fixed, what was broken
>  > before, how it was tested etc.
> 
> No test case, but that +2 doesn't make sense after looking at surrounding code and specs. Have a look at:
> 3GPP TS 52.021 §8.11.3 Get Attribute Response
> 3GPP TS 52.021 §9.4.64 Get Attribute Response Info

how about adding this to the commit log plz


-- 
To view, visit https://gerrit.osmocom.org/11683
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie61d70bc28427d5d879638516a36f590ce98bdc7
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 17:05:23 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/59c446fe/attachment.html>


More information about the gerrit-log mailing list