Change in osmo-bsc[master]: abis_nm: Add support to parse some nanoBTS Attribute Response attributes
Pau Espin Pedrol
gerrit-no-reply at lists.osmocom.org
Thu Nov 8 17:02:58 UTC 2018
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11681 )
Change subject: abis_nm: Add support to parse some nanoBTS Attribute Response attributes
Patch Set 2:
PS2, Line 23: first function to get a pointer to the list of attributes.
> this last bit seems to belong to a different patch? All I see in this patch is that you're directly […]
Yes, this is implemented (after re-splitting) in a previous patch (prior to this one). I still wanted to leave the entire comment here to make it easier to understand current code parts and how it is used.
I could re-write it as "As a result, parsing is currently split into 3 main parts or functions".
To view, visit https://gerrit.osmocom.org/11681
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 17:02:58 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log