Change in osmo-bsc[master]: abis_nm: Add support to parse some nanoBTS Attribute Response attributes

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 8 17:02:58 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11681 )

Change subject: abis_nm: Add support to parse some nanoBTS Attribute Response attributes
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11681/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11681/2//COMMIT_MSG@23
PS2, Line 23:   first function to get a pointer to the list of attributes.
> this last bit seems to belong to a different patch? All I see in this patch is that you're directly  […]
Yes, this is implemented (after re-splitting) in a previous patch (prior to this one). I still wanted to leave the entire comment here to make it easier to understand current code parts and how it is used.

I could re-write it as "As a result, parsing is currently split into 3 main parts or functions".



-- 
To view, visit https://gerrit.osmocom.org/11681
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52e9f177c14fec1ec3f5c4ddb244594409008357
Gerrit-Change-Number: 11681
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 17:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/2b4d81fa/attachment.html>


More information about the gerrit-log mailing list