Change in osmo-bsc[master]: abis_nm: Split attr parsing in Attribute Response Info into its own func

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 8 16:51:05 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11693 )

Change subject: abis_nm: Split attr parsing in Attribute Response Info into its own func
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.osmocom.org/#/c/11693/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11693/1//COMMIT_MSG@14
PS1, Line 14: which expect TLVs following an specific order, which is not mandatory.
well, now I'm confused which is what. Next time a separate patch plz


https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c@469
PS1, Line 469: /* Handle 3GPP TS 52.021 §8.11.3 Get Attribute Response (with nanoBTS speecific attribute formatting) */
speeecific


https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c@508
PS1, Line 508: 		LOGPFOH(DNM, LOGL_INFO, foh, "%s Get Attributes Response: nominal power is %u\n", gsm_trx_name(trx), *data);
changing from NOTICE to INFO? didn't see that in the commit log


https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c@530
PS1, Line 530: 
what with the 'return data + adjust' stuff before this patch ... useless cruft? remove separately and/or explain in commit log


https://gerrit.osmocom.org/#/c/11693/1/src/osmo-bsc/abis_nm.c@549
PS1, Line 549: 	/* After parsing unreported part of Response info, there's a TLV of attr, same as per nanoBTS */
I don't understand "a TLV of attr", what kind of attr / what for?



-- 
To view, visit https://gerrit.osmocom.org/11693
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec7a6e4d27639d0e5adc0d9a01cd3c3e7a46f558
Gerrit-Change-Number: 11693
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 16:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/eac6fb90/attachment.htm>


More information about the gerrit-log mailing list