Change in osmo-bsc[master]: check return value of gsm48_multirate_config()

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 8 16:10:37 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11629 )

Change subject: check return value of gsm48_multirate_config()
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/11629/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11629/1//COMMIT_MSG@13
PS1, Line 13: Because the VTY parsier limits the AMR mode range to 0-7 this
"Le Parsier, Sur La Tour Eiffel"


https://gerrit.osmocom.org/#/c/11629/1/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/11629/1/src/osmo-bsc/bsc_vty.c@4512
PS1, Line 4512: 			"Invalid AMR multirate configuration (%s, amr mode %d, ms) - check parameters%s",
("what, milliseconds?" -- maybe rather write in caps: MS and BTS; or maybe "Invalid AMR multirate config for MS")



-- 
To view, visit https://gerrit.osmocom.org/11629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61153a44e8b7a38332bf38718397be9b339d5f25
Gerrit-Change-Number: 11629
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 16:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/e344b0aa/attachment.html>


More information about the gerrit-log mailing list