Change in osmo-bsc[master]: abis_nm: Support parsing nanoBTS format for Get Attributes Info

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11695


Change subject: abis_nm: Support parsing nanoBTS format for Get Attributes Info
......................................................................

abis_nm: Support parsing nanoBTS format for Get Attributes Info

* On nanoBTS, the Get Attributes Response info can be at any position in the
  attribute list, and it only contains the unsupported attribute ID list.

Change-Id: I81a613d53bddf432a79fa5cb0bf9d847b4bdee37
---
M src/osmo-bsc/abis_nm.c
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/11695/1

diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index f089787..24b9429 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -461,7 +461,8 @@
 		     bts_nr, get_value_string(abis_nm_att_names, ari[i + 1]));
 
 	/* the data starts right after the list of unreported attributes + space for length of that list */
-	*out_len = ari_len - (num_unreported + 2);
+	if (out_len)
+		*out_len = ari_len - (num_unreported + 2);
 
 	return ari + num_unreported + 1; /* we have to account for 1st byte with number of unreported attributes */
 }
@@ -550,6 +551,13 @@
 		LOGPFOH(DNM, LOGL_ERROR, foh, "BTS%u Get Attributes Response: Unit ID is %s\n", bts->nr, unit_id);
 	}
 
+	/* nanoBTS provides Get Attribute Response Info at random position and only the unreported part of it. */
+	if (TLVP_PRES_LEN(tp, NM_ATT_GET_ARI, 1)) {
+		data = TLVP_VAL(tp, NM_ATT_GET_ARI);
+		len = TLVP_LEN(tp, NM_ATT_GET_ARI);
+		parse_attr_resp_info_unreported(bts->nr, data, len, NULL);
+	}
+
 	return 0;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/11695
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81a613d53bddf432a79fa5cb0bf9d847b4bdee37
Gerrit-Change-Number: 11695
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/18a1232a/attachment.htm>