This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11670 Change subject: lchan: set cause for 4 instances of release_in_error = true ...................................................................... lchan: set cause for 4 instances of release_in_error = true Make sure some RSL cause is set. Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083 --- M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/lchan_rtp_fsm.c 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/11670/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 012239c..bfcf55d 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -1054,6 +1054,7 @@ case LCHAN_EV_RSL_CHAN_ACTIV_ACK: /* A late Chan Activ ACK? Release. */ lchan->release.release_in_error = true; + lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING; lchan_fsm_state_chg(LCHAN_ST_WAIT_RF_RELEASE_ACK); return; @@ -1065,6 +1066,7 @@ case LCHAN_EV_RSL_RF_CHAN_REL_ACK: /* A late Release ACK? */ lchan->release.release_in_error = true; + lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING; lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR); /* TODO: we used to do this only for sysmobts: int do_free = is_sysmobts_v2(ts->trx->bts); @@ -1289,6 +1291,7 @@ default: lchan->release.release_in_error = true; + lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING; lchan_fail("Timeout"); return 0; } diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index dd42fc4..b6aa39c 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -725,6 +725,7 @@ { struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi); lchan->release.release_in_error = true; + lchan->release.rsl_error_cause = RSL_ERR_EQUIPMENT_FAIL; lchan_rtp_fail("Timeout"); return 0; } -- To view, visit https://gerrit.osmocom.org/11670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083 Gerrit-Change-Number: 11670 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/c06fa32c/attachment.htm>