Change in osmo-dev[master]: deps: comment out osmo-trx

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 7 15:55:27 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11634 )

Change subject: deps: comment out osmo-trx
......................................................................

deps: comment out osmo-trx

osmo-trx shouldn't run with address sanitizer. But omitting --enable-sanitize
from osmo-trx breaks 'make check', so then the whole top-level makefile will
end in error with sanitize.opts.

A user wanting to build osmo-trx can just uncomment that line.

Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
---
M 2G.deps
M 3G+2G.deps
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/2G.deps b/2G.deps
index cf2723a..c49589d 100644
--- a/2G.deps
+++ b/2G.deps
@@ -10,4 +10,7 @@
 osmo-msc	libosmo-sccp osmo-mgw libsmpp34
 osmo-bsc	libosmo-sccp osmo-mgw
 osmo-sgsn	libosmo-sccp osmo-ggsn osmo-hlr
-osmo-trx	libosmocore
+# osmo-trx can build with --enable-sanitize, but then won't work reliably.
+# When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail.
+# So if you want osmo-trx, uncomment and use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries.
+#osmo-trx	libosmocore
diff --git a/3G+2G.deps b/3G+2G.deps
index b82e7c9..e5d53fa 100644
--- a/3G+2G.deps
+++ b/3G+2G.deps
@@ -13,4 +13,7 @@
 osmo-bsc	libosmo-sccp osmo-mgw
 osmo-sgsn	osmo-iuh osmo-ggsn osmo-hlr
 osmo-sip-connector	libosmocore
-osmo-trx	libosmocore
+# osmo-trx can build with --enable-sanitize, but then won't work reliably.
+# When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail.
+# So if you want osmo-trx, uncomment and use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries.
+#osmo-trx	libosmocore

-- 
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181107/12607399/attachment.html>


More information about the gerrit-log mailing list